[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281946#comment-13281946
 ] 

Thomas Graves commented on MAPREDUCE-3350:
------------------------------------------

A few comments:

- can you update the web services documentation - 
./hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/ResourceManagerRest.apt.vm

- The Job block changes the name of the table based on if there was more then 1 
app master - we might want to make them match:     
String amString =
        amInfos.size() == 1 ? "ApplicationMaster" : "ApplicationMasters"; 

- The table div is #job, you might want to make #app: +    TABLE<DIV<Hamlet>> 
table = div.table("#job");
- The new attempt table doesn't does have row/column dividers (or show up in 
different colored stripes).  The history server table doesn't either. Is that 
something easy to add?

- It might make sense to add the fields containerId and nodeId to the 
appAttempt webservices output so that it matches what the job attempt is 
returning.
- can we add a webservices test with multiple app attempts?

                
> Per-app RM page should have the list of application-attempts like on the app 
> JHS page
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3350
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3350
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, webapps
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Jonathan Eagles
>            Priority: Critical
>             Fix For: 0.24.0
>
>         Attachments: MAPREDUCE-3350-branch-0.23.patch, MAPREDUCE-3350.patch, 
> MAPREDUCE-3350.patch, MAPREDUCE-3350.patch, MAPREDUCE-3350.patch, 
> MAPREDUCE-3350.patch, MAPREDUCE-3350.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to