[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400587#comment-13400587
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4346:
-----------------------------------------------

The JobStatus.setRetired(..) method should be package private, as it does not 
make sense for a client to set that value.

Please add a comment in the new method (where you are catching the exception) 
to state that this is done to ensure client API compatibility within this 
release.

What is the intended logic between status & retired? I would have assume it is 
an AND but it seems that retired TRUE trumps status (both in JT and client 
filtering logic).


                
> Adding a refined version of JobTracker.getAllJobs() and exposing through the 
> JobClient
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4346
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv1
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>         Attachments: MAPREDUCE-4346.patch, MAPREDUCE-4346_rev2.patch
>
>
> The current implementation for JobTracker.getAllJobs() returns all submitted 
> jobs in any state, in addition to retired jobs. This list can be long and 
> represents an unneeded overhead especially in the case of clients only 
> interested in jobs in specific state(s). 
> It is beneficial to include a refined version where only jobs having specific 
> statuses are returned and retired jobs are optional to include. 
> I'll be uploading an initial patch momentarily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to