[
https://issues.apache.org/jira/browse/MAPREDUCE-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401039#comment-13401039
]
Ahmed Radwan commented on MAPREDUCE-4346:
-----------------------------------------
Many tanks Tucu for the review! I have updated the patch per your comments:
- Changed JobStatus.setRetired(..) to package-private.
- Added description comment for the code handling the incompatibility case.
- For the intended logic of status and retired: I agree, it can be confusing. I
have added more description in the method comments in both the JobClient and
JobSubmissionProtocol to clarify the exact semantics of the method.
Please let me know if you have any further comments.
> Adding a refined version of JobTracker.getAllJobs() and exposing through the
> JobClient
> --------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4346
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4346
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv1
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4346.patch, MAPREDUCE-4346_rev2.patch,
> MAPREDUCE-4346_rev3.patch
>
>
> The current implementation for JobTracker.getAllJobs() returns all submitted
> jobs in any state, in addition to retired jobs. This list can be long and
> represents an unneeded overhead especially in the case of clients only
> interested in jobs in specific state(s).
> It is beneficial to include a refined version where only jobs having specific
> statuses are returned and retired jobs are optional to include.
> I'll be uploading an initial patch momentarily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
