[
https://issues.apache.org/jira/browse/MAPREDUCE-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797329#comment-13797329
]
Ravi Prakash commented on MAPREDUCE-3860:
-----------------------------------------
I compared the patch with branch-1. Here's my synopsis of the changes that I
noticed
h6. added files in src/test/resources
- Most of the files are the same. I haven't checked the rumen-test-data.tar.gz
. I presume the files in there are just the gzipped versions of the files in
the patch file. Andrey? In either case I am guessing the committer will like to
gzip the files her/himself.
- sample-conf.file.new.xml is a new file. It differs from sample-conf.file.xml
only in the older and newer mapred vs mapreduce config properties. This is fine
- job-tracker-logs-topology-output is different from the branch-1 file. I
wasn't entirely sure why. Andrey? Perhaps you can point me to the right branch
to look at?
h6. hadoop-mapreduce-client-hs/src/main changes seem fine
- Some methods have been made VisibleForTesting.
- createJobHistory() has been introduced so that tests may be able to override
it.
h6. hadoop-mapreduce-client-jobclient/src/test changes seem fine
- Changes to get JobFileInfo
h6. src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordList.java
- Any reason for this change? I couldn't find anywhere setSize() being used.
h6. hadoop-tools/hadoop-rumen/src/test/java/org/apache/hadoop/tools/rumen
changes
- TestConcurrentRead.java,TestZombieJob changes seem fine
- TestParsedLine is same as in branch-1
- I couldn't find TestRumenAnonymization,TestRumenFolder in branch-1. Any
pointers on where I may be able to find these files?
- TestRumenJobTraces had a lot of changes. I am wondering if a different
branch-1 has a closer match. Andrey? Otherwise I'll review the changes in
another comment.
> [Rumen] Bring back the removed Rumen unit tests
> -----------------------------------------------
>
> Key: MAPREDUCE-3860
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3860
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tools/rumen
> Reporter: Ravi Gummadi
> Assignee: Andrey Klochkov
> Attachments: MAPREDUCE-3860.patch, rumen-test-data.tar.gz
>
>
> MAPREDUCE-3582 did not move some of the Rumen unit tests to the new folder
> and then MAPREDUCE-3705 deleted those unit tests. These Rumen unit tests need
> to be brought back:
> TestZombieJob.java
> TestRumenJobTraces.java
> TestRumenFolder.java
> TestRumenAnonymization.java
> TestParsedLine.java
> TestConcurrentRead.java
--
This message was sent by Atlassian JIRA
(v6.1#6144)
