[
https://issues.apache.org/jira/browse/MAPREDUCE-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801931#comment-13801931
]
Ravi Prakash commented on MAPREDUCE-3860:
-----------------------------------------
Hi Andrey!
Thanks for your answers.
1. It will wait for 10s (100ms * 100), but you're right, that is tolerable too.
2. Aah! I did not know that. Thanks.
3. I agree that username should not be null after anonymization. So maybe we
should remove the line "anonymizedJob.getUser() != null &&"
4. I can see it either way and I'm not a stickler about either way. I'm fine
with how it is.
I would probaly classify all my comments as nits above. So I'm fine with this
patch. I'll let a committer make the final judgement call. Thanks Andrey!
> [Rumen] Bring back the removed Rumen unit tests
> -----------------------------------------------
>
> Key: MAPREDUCE-3860
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3860
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tools/rumen
> Reporter: Ravi Gummadi
> Assignee: Andrey Klochkov
> Attachments: MAPREDUCE-3860--n2.patch, MAPREDUCE-3860.patch,
> rumen-test-data.tar.gz
>
>
> MAPREDUCE-3582 did not move some of the Rumen unit tests to the new folder
> and then MAPREDUCE-3705 deleted those unit tests. These Rumen unit tests need
> to be brought back:
> TestZombieJob.java
> TestRumenJobTraces.java
> TestRumenFolder.java
> TestRumenAnonymization.java
> TestParsedLine.java
> TestConcurrentRead.java
--
This message was sent by Atlassian JIRA
(v6.1#6144)
