[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156927#comment-14156927
 ] 

Jason Lowe commented on MAPREDUCE-6029:
---------------------------------------

Thanks for the patch, Mit.  I agree with the premise that 100msec is probably 
too little, but I'm wondering about spurious wakeups.  If they occur then the 
test can still fail even with the larger timeout.  We should wait in a loop for 
either the event to be non-null or a duration of time to have elapsed.

> TestCommitterEventHandler fails in trunk
> ----------------------------------------
>
>                 Key: MAPREDUCE-6029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ted Yu
>            Assignee: Mit Desai
>         Attachments: MAPREDUCE-6029.patch
>
>
> From https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1857/console :
> {code}
> Running org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.429 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler
> testFailure(org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler)
>   Time elapsed: 1.198 sec  <<< FAILURE!
> java.lang.AssertionError: null
>       at org.junit.Assert.fail(Assert.java:86)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at org.junit.Assert.assertNotNull(Assert.java:621)
>       at org.junit.Assert.assertNotNull(Assert.java:631)
>       at 
> org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler.testFailure(TestCommitterEventHandler.java:314)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to