[jira] [Commented] (MAPREDUCE-6029) TestCommitterEventHandler fails in trunk

[Jason Lowe (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161037#comment-14161037
 ] 

Jason Lowe commented on MAPREDUCE-6029:
---------------------------------------

Thanks for the update Mit, but the latest change doesn't address the issue.  
The problem still can occur if we are spuriously woken up quickly for each of 
the 10 wait calls.  Granted this is not likely, but it is theoretically 
possible.  I was thinking something more along these lines:
{code}
if (event == null) {
  final waitTimeout = 5000;
  long waitStartTime = Time.monotonicNow();
  do {
    wait(waitTimeout);
  } while (event == null && Time.monotonicNow() - waitStartTime < waitTimeout);
}
{code}

> TestCommitterEventHandler fails in trunk
> ----------------------------------------
>
>                 Key: MAPREDUCE-6029
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6029
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ted Yu
>            Assignee: Mit Desai
>         Attachments: MAPREDUCE-6029.patch, MAPREDUCE-6029.patch
>
>
> From https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1857/console :
> {code}
> Running org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.429 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler
> testFailure(org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler)
>   Time elapsed: 1.198 sec  <<< FAILURE!
> java.lang.AssertionError: null
>       at org.junit.Assert.fail(Assert.java:86)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at org.junit.Assert.assertNotNull(Assert.java:621)
>       at org.junit.Assert.assertNotNull(Assert.java:631)
>       at 
> org.apache.hadoop.mapreduce.v2.app.commit.TestCommitterEventHandler.testFailure(TestCommitterEventHandler.java:314)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)