[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258815#comment-14258815
 ] 

Masatake Iwasaki commented on MAPREDUCE-6205:
---------------------------------------------

The value of "mapred.child.java.opts" seems to be used as fallback in 
MapReduceChildJVM#getChildJavaOpts. Is this not enough?
{code}
  private static String getChildJavaOpts(JobConf jobConf, boolean isMapTask) {
    String userClasspath = "";
    String adminClasspath = "";
    if (isMapTask) {
      userClasspath =
          jobConf.get(
              JobConf.MAPRED_MAP_TASK_JAVA_OPTS,
              jobConf.get(
                  JobConf.MAPRED_TASK_JAVA_OPTS,
                  JobConf.DEFAULT_MAPRED_TASK_JAVA_OPTS)
          );
{code}


> Update the value of the new version properties of the deprecated property 
> "mapred.child.java.opts"
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6205
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6205
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: trunk
>            Reporter: sam liu
>            Assignee: sam liu
>            Priority: Minor
>         Attachments: MAPREDUCE-6205.patch, MAPREDUCE-6205.patch
>
>
> In current hadoop code, the old property "mapred.child.java.opts" is 
> deprecated and its new versions are MRJobConfig.MAP_JAVA_OPTS and 
> MRJobConfig.REDUCE_JAVA_OPTS. However, when user set a value to the 
> deprecated property "mapred.child.java.opts", hadoop won't automatically 
> update its new versions properties 
> MRJobConfig.MAP_JAVA_OPTS("mapreduce.map.java.opts") and 
> MRJobConfig.REDUCE_JAVA_OPTS("mapreduce.reduce.java.opts"). As hadoop will 
> update the new version properties for many other deprecated properties, we 
> also should support such feature on the old property 
> "mapred.child.java.opts", otherwise it might bring some imcompatible issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to