[
https://issues.apache.org/jira/browse/MAPREDUCE-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260081#comment-14260081
]
Gera Shegalov commented on MAPREDUCE-6205:
------------------------------------------
[~sam liu], thanks for the patch.
# Please follow the guideline for including a version in patch names under
https://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch.
# The deprecation delta should be " mapred.child.java.opts" -> {
"mapred.map.child.java.opts", "mapred.reduce.child.java.opts" }. Otherwise you
introduce non-determinism due to existing deprecation deltas
"mapred.map|reduce.child.java.opts" -> "mapreduce.map|reduce.java.opts"
# mapred-default.xml should be updated. Currently
mapreduce.map|reduce.java.opts is commented out. Instead both should have thw
substitution value: {{$\{mapred.child.java.opts\}}}
> Update the value of the new version properties of the deprecated property
> "mapred.child.java.opts"
> --------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6205
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6205
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: trunk
> Reporter: sam liu
> Assignee: sam liu
> Priority: Minor
> Attachments: MAPREDUCE-6205.patch, MAPREDUCE-6205.patch
>
>
> In current hadoop code, the old property "mapred.child.java.opts" is
> deprecated and its new versions are MRJobConfig.MAP_JAVA_OPTS and
> MRJobConfig.REDUCE_JAVA_OPTS. However, when user set a value to the
> deprecated property "mapred.child.java.opts", hadoop won't automatically
> update its new versions properties
> MRJobConfig.MAP_JAVA_OPTS("mapreduce.map.java.opts") and
> MRJobConfig.REDUCE_JAVA_OPTS("mapreduce.reduce.java.opts"). As hadoop will
> update the new version properties for many other deprecated properties, we
> also should support such feature on the old property
> "mapred.child.java.opts", otherwise it might bring some imcompatible issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
