[
https://issues.apache.org/jira/browse/MAPREDUCE-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649651#comment-17649651
]
ASF GitHub Bot commented on MAPREDUCE-7429:
-------------------------------------------
slfan1989 commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053093731
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##########
@@ -229,6 +230,23 @@ public static InetSocketAddress createSocketAddr(String
target,
}
target = target.trim();
boolean hasScheme = target.contains("://");
+ if (StringUtils.countMatches(target, ":") > 2) {
+ // if scheme exists in the target, for example:
+ // https://ffff:ffff:ffff:ffff::1:XXXX will be formed like
+ // https://[ffff:ffff:ffff:ffff::1]:XXXX
Review Comment:
The code looks fine, we'd better use a specific port in the comments, such
as `8088`
> Application log link is not accessible via TimelineServer Web UI in IPV6
> scenario
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7429
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7429
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Daniel Ma
> Assignee: Daniel Ma
> Priority: Major
> Labels: pull-request-available
>
> Application log link is not accessible via TimelineServer Web UI in IPV6
> scenario owning to no ipv6 normalization.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
