[
https://issues.apache.org/jira/browse/MAPREDUCE-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649914#comment-17649914
]
ASF GitHub Bot commented on MAPREDUCE-7429:
-------------------------------------------
goiri commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053591430
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java:
##########
@@ -39,6 +39,7 @@
import java.util.concurrent.TimeUnit;
import org.apache.commons.lang3.StringUtils;
+import org.apache.ftpserver.command.impl.PORT;
Review Comment:
Why do we need this?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java:
##########
@@ -428,6 +429,12 @@ public static String getAggregatedLogURL(String
serverHttpAddress,
user == null || user.isEmpty()) {
return null;
}
+ String[] ipAdds = serverHttpAddress.split("//");
+ if (ipAdds.length >= 2 && StringUtils.countMatches(ipAdds[1], ":") > 2) {
Review Comment:
I think this is pretty much NetUtils.isIPV6Address
> Application log link is not accessible via TimelineServer Web UI in IPV6
> scenario
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7429
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7429
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Daniel Ma
> Assignee: Daniel Ma
> Priority: Major
> Labels: pull-request-available
>
> Application log link is not accessible via TimelineServer Web UI in IPV6
> scenario owning to no ipv6 normalization.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
