Hi Reinier, Awesome. Those plots are making me smile! I also agree with your refactoring and have applied your patch to my git repository.
I agree with you concerning the sympy plotting routines. I think what we have here is quite flexible and does a very good job of replicating the equivalent functionality of MATLAB. I think it would be a huge effort trying to make 2D plots and 3D plots look consistent if another approach was taken. Indeed, this is a desirable characteristic. In addition, the code is actually very short and easy to maintain. Given that matplotlib has had trouble maintaining 3D code in the past, it might not be a good idea to switch to a more complicated codebase. You should grab some of my more recent changes as I have added a few more fixes. Most importantly, if you reuse the same figure, the old event handlers will still attached preventing Axes objects from dieing and causing interactive manipulation of the plots to be very sluggish. Also, in terms of performance, I have found that switching to TkAgg from GTKAgg was helpful. Also, I think the original code from John Porter was under a BSD license. I am thinking of adding our names and the BSD license to the top of each file to protect it while its not officially part of matplotlib. What do you think? Best, Jonathan. On Sun, Mar 8, 2009 at 8:04 PM, Reinier Heeres <rein...@heeres.eu> wrote: > Hi, > > I've done some further refactoring of mplot3d: > > - Almost all of the test plotting functions work, except for > test_bar2D. Filled contours are not perfect yet and need a bit more > work. Try "python axes.py" with the attached files to see how it > looks! > > - I removed the Wrap2D class, which was using private class members > throughout. I replaced this approach with dynamically changing the > class type for Artist objects (e.g. PolyCollection to > Poly3DCollection). This is also a bit of voodoo, but I think in the > end it results in a bit less code, which is also more readable. > > - Much more code could still be removed (and added again later if necessary) > > Regards, > Reinier > > BTW: I think plugging sympy's plotting functionality into matplotlib > would not be so easy! The mplot3d code is much better suited for > this... > > On Thu, Mar 5, 2009 at 7:13 PM, Gael Varoquaux > <gael.varoqu...@normalesup.org> wrote: >> On Thu, Mar 05, 2009 at 07:03:00PM +0100, Cohen-Tanugi Johann wrote: >>> Nevertheless, I hate to think of matplotlib sending people to mayavi2 each >>> time 3D plotting is needed. Basic functionalities built-in would still be >>> highly desirable. >> >> Absolutely. I think we need basic 3D plotting functionnality that work >> without any 3D rendering library, both for robustess and for simplicity. >> >> I used to think different, because I believe that this approach is bound >> to fail on anything but very simple problems (my experience with gnuplot >> :>). I fear people are going to try and pull too far the simple 3D >> implementation. >> >> Nevertheless, it would be great to have some 3D in matplotlib, for easier >> mixing of 2D and 3D (I do this with Mayavi2 by saving to a temporary >> file, loading the result with matplotlib's imread, and displaying it with >> an imshow -- ugly!), and to have backend-universal, robust, 3D plotting. >> >> Gaël >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Matplotlib-devel mailing list >> Matplotlib-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel >> > > > > -- > Reinier Heeres > Waalstraat 17 > 2515 XK Den Haag > The Netherlands > > Tel: +31 6 10852639 > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Matplotlib-devel mailing list > Matplotlib-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel > > ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
