On Sun, Oct 20, 2013 at 9:45 AM, Todd <toddr...@gmail.com> wrote:
> Hello,
>
> I submitted a pull request #2522 [1]. It includes support for more basic
> spectrum plots like magnitude and phase spectrums. These are extremely
> commonly used in signal processing, acoustics, and many other fields, but
> are also very important for educational usage since pretty much anyone
> going through one of several engineering degrees like electrical
> engineering has to learn these types of plots. I have heard a number of
> colleagues complaining about the lack of these plots in matlab.
>
> It has been up for 5 days, but I haven't received any comments on its
> content or structure. I understand that it is a pretty substantial patch,
> but I think the features are very useful.
>
> I am also a bit concerned that patches covering the same code might be
> submitted and accepted while I am waiting for this, since such changes
> would be hard to merge into my branch.
>
> So does anyone have any thoughts on the patch?
>
> [1] https://github.com/matplotlib/matplotlib/pull/2522
>
I do have one question about my pull request.
Currently, both axes.psd and axes.csd return the same thing as mlab.psd and
mlab.csd, namely the spectrum and frequency points. They do NOT return the
line object that was plotted. This is different than specgram, which
returns the AxesImage object that was plotted in addition to the
mlab.specgram return values.
I think having access to the line object is important, so
axes.magnitude_spectrum, axes.angle_spectrum, and axes.phase_spectrum do
return the line object. I know this is inconsistent, but I think it is
very important and would strongly objefct to removing this.
The question, then, is whether this would be a good opportunity to add the
line object to the returned values for axes.psd and axes.csd. This would
be an API break, but would be very easy to fix, and it may be beneficial
enough to warrant it. What does everyone think?
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
