David Baird wrote:
> I've done a bit of gentle refactoring in Maypole.pm, take a look and
> see if it makes sense. Haven't changed any logic, just split some
> stuff in handler_guts into separate methods, and changed any direct
> hash accesses into proper method calls. Also, translated the return
> code from is_applicable into a boolean, to remove one set of status
> values from handler_guts. I put the view processing stanza into a
> separate method and I'm intending to move that out of handler_guts()
> and into handler(). Stop me if I start changing stuff you feel we
> haven't reached a consensus on yet.
Sorry, I have a number of questions about this.
Let me start with a minor quibble. One of the things that I like about
Maypole was that the code was maintained to a maximum width of 80
columns. It suits the way I lay my screen out. Any chance we can
continue this practice? It's a pain to have to resize my windows to a
different size for different files. To an even more minor degree, I
don't like all the extra blank lines - they mean I can't comprehend as
much in a screenful. I can run perltidy so I can read the code but that
doesn't fix comments.
Most importantly, I thought the plan was to to document and clarify
first? I don't think we've done that, have we? Refactoring Maypole.pm
isn't on the roadmap is it?
Somewhere in between in importance, I don't understand the purpose of
all the __xxx methods. Since they're private, they can't be overridden,
so what's their value? Especially since two are only one line long?
What's the point in moving the view processing? I must be missing
something again - perhaps the documentation?
I don't like the changes to call_authenticate. Changing $self to $r
makes it less obvious what's happening, and Simon's comment was more
helpful, IMHO.
Sorry!
I do like the idea of using the attribute accessor methods instead of
making direct use of the underlying hash.
And the code for param() is neater :)
Cheers, Dave
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
Maypole-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/maypole-devel
