On 10/5/05, David Baird <[EMAIL PROTECTED]> wrote: > On 10/5/05, Dave Howorth <[EMAIL PROTECTED]> wrote: > > I expressed some doubts about various aspects of the refactoring work on > > Maypole.pm. So here's a concrete suggestion for one of those aspects - > > refactoring is_applicable. > > > > I think the goal was to make the code more readable by changing > > is_applicable to return a truth value instead of an Apache return code. > > > > But the proposal was to add an extra subroutine, which IMHO doesn't move > > us closer to that goal. I think the attached patch does move us towards > > the goal and also fixes a couple of other niggles in the method. > > > > Cheers, Dave > > > > Yes! Much better, better name too, are you going to commit it?
Works for me. Speaking of apache return codes.. actually that should go in a new mail - which I'll do at lunchtime.. > BTW, have we agreed that $r should be $self? Best to check the archive.. I thought we were sticking with $r but then I've been pre-occupied with finding a new job since handing in my notice at work :( A. ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ Maypole-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/maypole-devel
