ArielGlenn has submitted this change and it was merged.

Change subject: beta: parsoid init script needs root
......................................................................


beta: parsoid init script needs root

In 6dc57210 I added a sudo access to let jenkins-deploy user restart the
Parsoid daemon using 'parsoid' as user. Turns out init scripts need root
access :-/

This patch change the sudo_user permission from parsoid to root.

bug: 57233
Change-Id: I7fb1f2e5e106a19341e71a10bc45d55256ade17f
---
M manifests/role/parsoid.pp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  ArielGlenn: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/role/parsoid.pp b/manifests/role/parsoid.pp
index 6f6607a..626cb7d 100644
--- a/manifests/role/parsoid.pp
+++ b/manifests/role/parsoid.pp
@@ -79,9 +79,9 @@
 
     sudo_user { 'jenkins-deploy': privileges => [
         # Need to allow jenkins-deploy to reload parsoid
-        # Since the "parsoid" user is local, we cant add the sudo policy in
+        # Since the "root" user is local, we cant add the sudo policy in
         # OpenStack manager interface at wikitech
-        'ALL = (parsoid) NOPASSWD:/etc/init.d/parsoid',
+        'ALL = (root) NOPASSWD:/etc/init.d/parsoid',
     ] }
 
     file { '/var/lib/parsoid/Parsoid':

-- 
To view, visit https://gerrit.wikimedia.org/r/98798
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fb1f2e5e106a19341e71a10bc45d55256ade17f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: ArielGlenn <ar...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to