Legoktm has submitted this change and it was merged.

Change subject: Call Linker::link statically (1.18)
......................................................................


Call Linker::link statically (1.18)

Change-Id: I1fbddd4f53be1f5cb76b8ef4ca6082fd26290318
---
M specials/PS_GeneratePages.php
1 file changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Legoktm: Verified; Looks good to me, approved



diff --git a/specials/PS_GeneratePages.php b/specials/PS_GeneratePages.php
index 47c3e1f..1149bb4 100644
--- a/specials/PS_GeneratePages.php
+++ b/specials/PS_GeneratePages.php
@@ -66,18 +66,12 @@
                                $pageList[] = $page;
                        }
                }
-               // SpecialPage::getSkin() was added in MW 1.18
-               if ( is_callable( $this, 'getSkin' ) ) {
-                       $skin = $this->getSkin();
-               } else {
-                       global $wgUser;
-                       $skin = $wgUser->getSkin();
-               }
+
                foreach ( $pageList as $page ) {
                        if ( !( $page instanceof Title ) ) { continue; }
                        $pageName = PageSchemas::titleString( $page );
                        $text .= Html::input( 'page[]', $pageName, 'checkbox', 
array( 'checked' => true ) );
-                       $text .= "\n" . $skin->link( $page ) . "<br />\n";
+                       $text .= "\n" . Linker::link( $page ) . "<br />\n";
                }
                $text .= "<br />\n";
                $text .= Html::input( null, wfMessage( 'generatepages' 
)->parse(), 'submit' );

-- 
To view, visit https://gerrit.wikimedia.org/r/106743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1fbddd4f53be1f5cb76b8ef4ca6082fd26290318
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageSchemas
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: IAlex <coderev...@emsenhuber.ch>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: NormalUser <c...@anyonecanedit.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to