Hardikj has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/112401

Change subject: Bug 60753 - Images: Empty link not accepted in image caption
......................................................................

Bug 60753 - Images: Empty link not accepted in image caption

Change-Id: I484b591fc0e2711d81f6f4a834889df1ca537991
---
M lib/pegTokenizer.pegjs.txt
1 file changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/01/112401/1

diff --git a/lib/pegTokenizer.pegjs.txt b/lib/pegTokenizer.pegjs.txt
index ee7a55f..ab4b44c 100644
--- a/lib/pegTokenizer.pegjs.txt
+++ b/lib/pegTokenizer.pegjs.txt
@@ -1159,7 +1159,7 @@
     ! url
     //target:link_target
     // XXX: disallow pipe!
-    target:wikilink_preprocessor_text
+    target:wikilink_preprocessor_text?
     tpos:({return pos;})
     lcontent:wikilink_content?
     "]]"
@@ -1169,6 +1169,16 @@
       }
       //console.warn('lcontent: ' + JSON.stringify( lcontent, null, 2 ) );
 
+      if ( target === '' ){
+        var src = "[[]]";
+        var obj1 = new TagTk( 'span', 
+                              [ new KV( 'typeof', 'mw:Placeholder' ) ], 
+                              { src: src, tsr: [pos0, pos] } 
+                        );
+        var obj2 = new EndTagTk( 'span', [], { tsr: [pos, pos] } )
+        return [obj1, src, obj2];
+      }
+
       var obj = new SelfclosingTagTk( 'wikilink' ),
           textTokens = [],
           hrefKV = new KV('href', target);

-- 
To view, visit https://gerrit.wikimedia.org/r/112401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I484b591fc0e2711d81f6f4a834889df1ca537991
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Hardikj <hardikjuneja...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to