Alexandros Kosiaris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116978
Change subject: Fix ruby stability hash issue in recursor.conf
......................................................................
Fix ruby stability hash issue in recursor.conf
Using the de-facto standard of sort.map on a hash we avoid an issue
with ruby hashes not having their key/value pairs consistently placed
and the resulting file changing every few invocations
Change-Id: I870e546e3da420e4924afa04bb5815ccbd4a9bab
---
M templates/powerdns/recursor.conf.erb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/78/116978/1
diff --git a/templates/powerdns/recursor.conf.erb
b/templates/powerdns/recursor.conf.erb
index e6a198d..f265bf8 100644
--- a/templates/powerdns/recursor.conf.erb
+++ b/templates/powerdns/recursor.conf.erb
@@ -6,7 +6,7 @@
result = []
if ips.is_a?(Hash) then
- ips.values.each do |v|
+ ips.sort.map do |k, v|
result += flatten_ips(v)
end
elsif ips.is_a?(Array) then
--
To view, visit https://gerrit.wikimedia.org/r/116978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I870e546e3da420e4924afa04bb5815ccbd4a9bab
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
