Alexandros Kosiaris has submitted this change and it was merged. Change subject: Fix ruby stability hash issue in recursor.conf ......................................................................
Fix ruby stability hash issue in recursor.conf Using the de-facto standard of sort.map on a hash we avoid an issue with ruby hashes not having their key/value pairs consistently placed and the resulting file changing every few invocations Change-Id: I870e546e3da420e4924afa04bb5815ccbd4a9bab --- M templates/powerdns/recursor.conf.erb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexandros Kosiaris: Looks good to me, approved jenkins-bot: Verified diff --git a/templates/powerdns/recursor.conf.erb b/templates/powerdns/recursor.conf.erb index e6a198d..f265bf8 100644 --- a/templates/powerdns/recursor.conf.erb +++ b/templates/powerdns/recursor.conf.erb @@ -6,7 +6,7 @@ result = [] if ips.is_a?(Hash) then - ips.values.each do |v| + ips.sort.map do |k, v| result += flatten_ips(v) end elsif ips.is_a?(Array) then -- To view, visit https://gerrit.wikimedia.org/r/116978 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870e546e3da420e4924afa04bb5815ccbd4a9bab Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org> Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits