jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Remove undefined test and unused rule
......................................................................
Hygiene: Remove undefined test and unused rule
ran "make cucumber"
Not sure how this test in watchlist.feature didn't get deleted
It's covered in mainmenu.feature - probably a rebase issue.
The not logged in step is not used anywhere
Change-Id: I6cdf41f111a689c6a20d3cdffe575e0ab41423ac
---
M tests/browser/features/step_definitions/common_steps.rb
M tests/browser/features/watchlist.feature
2 files changed, 0 insertions(+), 11 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index 4e3c029..4818e7e 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -85,10 +85,6 @@
end
end
-Given /^I am not logged in$/ do
- # nothing to do here, user in not logged in by default
-end
-
Given(/^I am on the "(.+)" page$/) do |article|
visit(ArticlePage, :using_params => {:article_name => article})
end
diff --git a/tests/browser/features/watchlist.feature
b/tests/browser/features/watchlist.feature
index b2f1035..512c6dd 100644
--- a/tests/browser/features/watchlist.feature
+++ b/tests/browser/features/watchlist.feature
@@ -1,13 +1,6 @@
@en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org
Feature: Manage Watchlist
- Scenario: Clicking the watchlist item in main menu when anonymous
- Given I am on the "Main Page" page
- And I am not logged in
- When I click on "Watchlist" in the main navigation menu
- Then I receive watchlist message A watchlist helps you bookmark pages and
keep track of changes to them.
- And I receive watchlist message Log in to see it.
-
@login
Scenario: Add an article to the watchlist
Given I am logged into the mobile website
--
To view, visit https://gerrit.wikimedia.org/r/118209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cdf41f111a689c6a20d3cdffe575e0ab41423ac
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
