Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/118709

Change subject: Fix error: timidity service can not be stopped
......................................................................

Fix error: timidity service can not be stopped

The timidity package is required by the Score MediaWiki extensions and
has been added in Nov 2012 as a dependency of wikimedia-task-appserver.
I suspect the package on Lucid provided and started a daemon which is
not recommended, hence a change that made puppet to ensure the daemon
does not run: https://gerrit.wikimedia.org/r/#/c/34262/

When bootstrapping instances for beta I came with the error:

  err: /Stage[main]/Mediawiki/Service[timidity]:
   Could not evaluate:
    Could not find init script for 'timidity'

The 'timidity' package is installed but there is no init script since it
comes from the uninstalled package 'timidity-daemon'.  If we ensure the
package is gone, I guess the service will be out as well.

Change-Id: I4a04e5eb94e1acb46373b28f620d434c8cd3a776
---
M modules/mediawiki/manifests/init.pp
1 file changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/09/118709/1

diff --git a/modules/mediawiki/manifests/init.pp 
b/modules/mediawiki/manifests/init.pp
index 5effd82..5069351 100644
--- a/modules/mediawiki/manifests/init.pp
+++ b/modules/mediawiki/manifests/init.pp
@@ -9,10 +9,16 @@
        }
 
        # Disable timidity-daemon
-       # It's recommended by timidity and there's no simple way to avoid 
installing it
-       service { 'timidity':
-               enable => false,
-               ensure => stopped;
+       #
+       # Timidity is a dependency for the MediaWiki extension Score and is
+       # installed via wikimedia-task-appserver.
+       #
+       # The 'timidity' package used to install the daemon, but it is 
recommended
+       # to disable it anyway. In Precise, the daemon is provided by a package
+       # 'timidity-daemon', so we just need to ensure it is not installed to
+       # disable it properly.
+       package { 'timidity-daemon':
+               ensure => absent,
        }
 
        include users::mwdeploy, users::l10nupdate, users::sudo, sync, cgroup, 
packages

-- 
To view, visit https://gerrit.wikimedia.org/r/118709
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a04e5eb94e1acb46373b28f620d434c8cd3a776
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <has...@free.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to