jenkins-bot has submitted this change and it was merged.
Change subject: Increase the network performance sampling rate for MediaViewer
......................................................................
Increase the network performance sampling rate for MediaViewer
Since Media Viewer is a beta feature at the moment, we're
collecting too little data at the current sampling rate to make
truly informed decisions about performance. This patch changes
sampling from 1:1000 to 1:10 for non-pilot sites.
Change-Id: Ib539f96eb79707549c31cef6898920e0340e41f1
---
M wmf-config/CommonSettings-labs.php
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings-labs.php
M wmf-config/InitialiseSettings.php
4 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
Catrope: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/wmf-config/CommonSettings-labs.php
b/wmf-config/CommonSettings-labs.php
index 92e532d..b0e89f3 100644
--- a/wmf-config/CommonSettings-labs.php
+++ b/wmf-config/CommonSettings-labs.php
@@ -72,7 +72,7 @@
if ( $wmgUseMultimediaViewer ) {
require_once( "$IP/extensions/MultimediaViewer/MultimediaViewer.php" );
- $wgNetworkPerformanceSamplingFactor = 1;
+ $wgNetworkPerformanceSamplingFactor =
$wmgNetworkPerformanceSamplingFactor;
if ( $wmgMediaViewerBeta ) {
$wgMediaViewerIsInBeta = true;
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 13a8a8d..38d1fa1 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -1766,7 +1766,7 @@
if ( $wmgUseMultimediaViewer ) {
require_once( "$IP/extensions/MultimediaViewer/MultimediaViewer.php" );
- $wgNetworkPerformanceSamplingFactor = 1000;
+ $wgNetworkPerformanceSamplingFactor =
$wmgNetworkPerformanceSamplingFactor;
if ( $wmgMediaViewerBeta ) {
$wgMediaViewerIsInBeta = true;
diff --git a/wmf-config/InitialiseSettings-labs.php
b/wmf-config/InitialiseSettings-labs.php
index 9abbce8..8807d01 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -272,6 +272,10 @@
'default' => false,
),
+ 'wmgNetworkPerformanceSamplingFactor' => array(
+ 'default' => 1,
+ ),
+
'wmgUseVectorBeta' => array(
'default' => true,
),
diff --git a/wmf-config/InitialiseSettings.php
b/wmf-config/InitialiseSettings.php
index c543b20..3524cf1 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -10716,6 +10716,11 @@
'default' => false,
),
+'wmgNetworkPerformanceSamplingFactor' => array(
+ 'default' => 10, // beta feature users do not generate enough data with
1:1000
+ 'mediaviewer' => 1000,
+),
+
// -------------- VisualEditor start --------------
'wmgUseParsoid' => array(
--
To view, visit https://gerrit.wikimedia.org/r/119269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib539f96eb79707549c31cef6898920e0340e41f1
Gerrit-PatchSet: 7
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
