Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/120816
Change subject: Assert that JS has loaded in performance test ...................................................................... Assert that JS has loaded in performance test Currently we are just loading the item page and assume everything is fine when it finished loading. That makes the performance graph incorrect as a page loads faster when JS is broken and not get loaded. So we have to check that the JS UI has loaded and is working. Change-Id: I43ab3adb291e75c6b24867acd039a165c04eb1bf --- M tests/browser/features/performance_test.feature M tests/browser/features/step_definitions/performance_test_steps.rb 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/16/120816/1 diff --git a/tests/browser/features/performance_test.feature b/tests/browser/features/performance_test.feature index b25d66b..8debe38 100644 --- a/tests/browser/features/performance_test.feature +++ b/tests/browser/features/performance_test.feature @@ -11,8 +11,10 @@ Given Entity Italy defined in data/q38.json exists Scenario Outline: Loading a huge entity - Then get loading time of <page> + When I load the huge item <item> + And I click the label edit button + Then Label input element should be there Examples: - | page | + | item | | Italy | \ No newline at end of file diff --git a/tests/browser/features/step_definitions/performance_test_steps.rb b/tests/browser/features/step_definitions/performance_test_steps.rb index 6ec100e..ece1add 100644 --- a/tests/browser/features/step_definitions/performance_test_steps.rb +++ b/tests/browser/features/step_definitions/performance_test_steps.rb @@ -7,7 +7,7 @@ items_under_test = {} -Given(/^Entity (.+) defined in (.+) exists$/) do |pagename, data_file| +Given /^Entity (.+) defined in (.+) exists$/ do |pagename, data_file| wb_api = WikibaseAPI::Gateway.new(URL.repo_api) wb_api.login(ENV["WB_REPO_USERNAME"], ENV["WB_REPO_PASSWORD"]) @@ -19,7 +19,7 @@ items_under_test[pagename] = item_under_test end -Then(/^get loading time of (.+)$/) do |pagename| +When /^I load the huge item (.+)$/ do |pagename| on(ItemPage) do |page| page.navigate_to items_under_test[pagename]["url"] page.wait_for_entity_to_load -- To view, visit https://gerrit.wikimedia.org/r/120816 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I43ab3adb291e75c6b24867acd039a165c04eb1bf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits