jenkins-bot has submitted this change and it was merged.
Change subject: Assert that JS has loaded in performance test
......................................................................
Assert that JS has loaded in performance test
Currently we are just loading the item page and assume everything is fine
when it finished loading. That makes the performance graph incorrect as a
page loads faster when JS is broken and not get loaded. So we have to
check that the JS UI has loaded and is working.
Change-Id: I43ab3adb291e75c6b24867acd039a165c04eb1bf
---
M tests/browser/features/performance_test.feature
M tests/browser/features/step_definitions/performance_test_steps.rb
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
WikidataJenkins: Verified
Adrian Lang: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/performance_test.feature
b/tests/browser/features/performance_test.feature
index b25d66b..83d8caa 100644
--- a/tests/browser/features/performance_test.feature
+++ b/tests/browser/features/performance_test.feature
@@ -11,8 +11,10 @@
Given Entity Italy defined in data/q38.json exists
Scenario Outline: Loading a huge entity
- Then get loading time of <page>
+ When I load the huge item <item>
+ Then Label edit button should be there
+ And Javascript UI should be initialized
Examples:
- | page |
+ | item |
| Italy |
\ No newline at end of file
diff --git a/tests/browser/features/step_definitions/performance_test_steps.rb
b/tests/browser/features/step_definitions/performance_test_steps.rb
index 6ec100e..3e9dbde 100644
--- a/tests/browser/features/step_definitions/performance_test_steps.rb
+++ b/tests/browser/features/step_definitions/performance_test_steps.rb
@@ -7,7 +7,7 @@
items_under_test = {}
-Given(/^Entity (.+) defined in (.+) exists$/) do |pagename, data_file|
+Given /^Entity (.+) defined in (.+) exists$/ do |pagename, data_file|
wb_api = WikibaseAPI::Gateway.new(URL.repo_api)
wb_api.login(ENV["WB_REPO_USERNAME"], ENV["WB_REPO_PASSWORD"])
@@ -19,9 +19,13 @@
items_under_test[pagename] = item_under_test
end
-Then(/^get loading time of (.+)$/) do |pagename|
+When /^I load the huge item (.+)$/ do |pagename|
on(ItemPage) do |page|
page.navigate_to items_under_test[pagename]["url"]
page.wait_for_entity_to_load
end
end
+
+Then /^Javascript UI should be initialized$/ do
+ on(ItemPage).edit_label_link_element.attribute("href").should ==
"javascript:void(0);"
+end
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/120816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43ab3adb291e75c6b24867acd039a165c04eb1bf
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
