Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/126910
Change subject: Temporary hack for VE math inspector closing issues in 1.23wmf22; fixed in 1.24wmf1 ...................................................................... Temporary hack for VE math inspector closing issues in 1.23wmf22; fixed in 1.24wmf1 Change-Id: I7cf1f779a8275ac0a54e125196a79e37065b56ad --- M modules/VisualEditor/ve.ui.MWMathInspector.js 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math refs/changes/10/126910/1 diff --git a/modules/VisualEditor/ve.ui.MWMathInspector.js b/modules/VisualEditor/ve.ui.MWMathInspector.js index ac62041..77385de 100644 --- a/modules/VisualEditor/ve.ui.MWMathInspector.js +++ b/modules/VisualEditor/ve.ui.MWMathInspector.js @@ -62,6 +62,8 @@ // Parent method ve.ui.MWExtensionInspector.prototype.setup.call( this, data ); + this.dontClose = true; + this.getFragment().getSurface().pushStaging(); var mwData; @@ -93,6 +95,18 @@ // Override directionality settings, inspector's input // should always be LTR: this.input.setRTL( false ); + + this.dontClose = false; +}; + +ve.ui.MWMathInspector.prototype.close = function () { + // HACK ignore close() calls while setting up + // This works around the fact that inserting a focusable node + // causes a focus event in 1.23wmf22 but not in 1.24wmf1 + if ( !this.dontClose ) { + // Parent method + ve.ui.MWExtensionInspector.prototype.close.apply( this, arguments ); + } }; /** -- To view, visit https://gerrit.wikimedia.org/r/126910 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7cf1f779a8275ac0a54e125196a79e37065b56ad Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Math Gerrit-Branch: wmf/1.23wmf22 Gerrit-Owner: Catrope <roan.katt...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits