jenkins-bot has submitted this change and it was merged.
Change subject: (bug 64137) Some more Page.title() testing
......................................................................
(bug 64137) Some more Page.title() testing
Fix for bug 64137 (AssertionError if config.family isn't 'wikipedia'
Change-Id: Ia7762de0a99b1121deec2df3d936b9d82d6a74f3
---
M tests/page_tests.py
1 file changed, 44 insertions(+), 2 deletions(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/page_tests.py b/tests/page_tests.py
index 2ae3b26..f4def99 100644
--- a/tests/page_tests.py
+++ b/tests/page_tests.py
@@ -111,9 +111,14 @@
class TestPageObject(PywikibotTestCase):
+
def testGeneral(self):
- self.assertEqual(str(mainpage), "[[%s:%s]]"
- % (site.lang, mainpage.title()))
+ family_name = (site.family.name + ':'
+ if pywikibot.config2.family != site.family.name
+ else u'')
+ self.assertEqual(str(mainpage), "[[%s%s:%s]]"
+ % (family_name, site.code,
+ mainpage.title()))
self.assertTrue(mainpage < maintalk)
def testSite(self):
@@ -186,6 +191,43 @@
self.assertEqual(p2.title(asLink=True, textlink=True,
withNamespace=False, insite=site),
u"[[:File:Jean-Léon Gérôme 003.jpg|Jean-Léon Gérôme
003.jpg]]")
+ # at last test article namespace
+ p2 = pywikibot.Page(site, u"Test page")
+ self.assertEqual(p2.title(),
+ u"Test page")
+ self.assertEqual(p2.title(underscore=True),
+ u"Test_page")
+ self.assertEqual(p2.title(),
+ p2.title(withNamespace=False))
+ self.assertEqual(p2.title(),
+ p2.title(withSection=False))
+ self.assertEqual(p2.title(asUrl=True),
+ p2.title(underscore=True))
+ self.assertEqual(p2.title(asLink=True, insite=site),
+ u"[[Test page]]")
+ self.assertEqual(p2.title(as_filename=True),
+ p2.title(underscore=True))
+ self.assertEqual(p2.title(underscore=True),
+ p2.title(underscore=True, withNamespace=False))
+ self.assertEqual(p2.title(underscore=True),
+ p2.title(underscore=True, withSection=False))
+ self.assertEqual(p2.title(underscore=True, asUrl=True),
+ p2.title(underscore=True))
+ self.assertEqual(p2.title(underscore=True, asLink=True, insite=site),
+ p2.title(asLink=True, insite=site))
+ self.assertEqual(p2.title(underscore=True, as_filename=True),
+ p2.title(underscore=True))
+ self.assertEqual(p2.title(),
+ p2.title(withNamespace=False, withSection=False))
+ self.assertEqual(p2.title(asUrl=True),
+ p2.title(withNamespace=False, asUrl=True))
+ self.assertEqual(p2.title(asLink=True, insite=site),
+ p2.title(withNamespace=False, asLink=True,
insite=site))
+ self.assertEqual(p2.title(as_filename=True),
+ p2.title(withNamespace=False, as_filename=True))
+ self.assertEqual(p2.title(withNamespace=False, asLink=True,
+ forceInterwiki=True, insite=site),
+ u"[[en:Test page|Test page]]")
def testSection(self):
"""Test section() method."""
--
To view, visit https://gerrit.wikimedia.org/r/127435
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7762de0a99b1121deec2df3d936b9d82d6a74f3
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
