jenkins-bot has submitted this change and it was merged.

Change subject: SimpleCaptcha: Move the equals sign inside the <label/>
......................................................................


SimpleCaptcha: Move the equals sign inside the <label/>

The old style does not cooperate well with the new pretty forms in
core MediaWiki, and arguably this should be done like this anyway.

Bug: 63606
Change-Id: Ifbe41ee5787bd4ed9e6144c06cd1d16f72354061
---
M Captcha.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Captcha.php b/Captcha.php
index 746b890..c6a05b1 100644
--- a/Captcha.php
+++ b/Captcha.php
@@ -38,7 +38,7 @@
                $captcha = $this->getCaptcha();
                $index = $this->storeCaptcha( $captcha );
 
-               return "<p><label 
for=\"wpCaptchaWord\">{$captcha['question']}</label> = " .
+               return "<p><label for=\"wpCaptchaWord\">{$captcha['question']} 
= </label>" .
                        Xml::element( 'input', array(
                                'name' => 'wpCaptchaWord',
                                'id'   => 'wpCaptchaWord',

-- 
To view, visit https://gerrit.wikimedia.org/r/124357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbe41ee5787bd4ed9e6144c06cd1d16f72354061
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to