Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/135427
Change subject: Officially deprecate skin autodiscovery ...................................................................... Officially deprecate skin autodiscovery Corresponding change in master (core skins no longer use autodiscovery there, but it's too scary of a change to backport here at last minute): I6fc30f97d4b35820c132c4892abf6d2c86f9482e. Change-Id: If9125ef587ce11f0d69f12eacd00ae7236139798 --- M RELEASE-NOTES-1.23 M includes/Skin.php 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/27/135427/1 diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23 index e8bd9e7..b44fdaa 100644 --- a/RELEASE-NOTES-1.23 +++ b/RELEASE-NOTES-1.23 @@ -359,6 +359,9 @@ to use different names to or re-bind them at the top of each ResourceLoader-loaded module. * (bug 52342) Preference "Remember my login" was removed. +* The skin autodiscovery mechanism has been deprecated and will be removed in + MediaWiki 1.25. See https://www.mediawiki.org/wiki/Help:Skin_autodiscovery for + migration guide for creators and users of custom skins that relied on it. ==== Removed classes ==== * FakeMemCachedClient (deprecated in 1.18) diff --git a/includes/Skin.php b/includes/Skin.php index d4608ff..f9f4c2c 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -64,6 +64,16 @@ if ( preg_match( '/^([^.]*)\.php$/', $file, $matches ) ) { $aSkin = $matches[1]; + + // We're still loading core skins via the autodiscovery mechanism... :( + if ( !in_array( $aSkin, array( 'CologneBlue', 'Modern', 'MonoBook', 'Vector' ) ) ) { + wfLogWarning( + "A skin using autodiscovery mechanism, $aSkin, was found in your skins/ directory. " . + "The mechanism will be removed in MediaWiki 1.25 and the skin will no longer be recognized. " . + "See https://www.mediawiki.org/wiki/Help:Skin_autodiscovery for information how to fix this." + ); + } + $wgValidSkinNames[strtolower( $aSkin )] = $aSkin; } } -- To view, visit https://gerrit.wikimedia.org/r/135427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If9125ef587ce11f0d69f12eacd00ae7236139798 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_23 Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
