Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/135429
Change subject: Officially deprecate skin autodiscovery ...................................................................... Officially deprecate skin autodiscovery Corresponding change in REL1_23 (different, because core skins still use autodiscovery in that version): If9125ef587ce11f0d69f12eacd00ae7236139798. Change-Id: I6fc30f97d4b35820c132c4892abf6d2c86f9482e --- M RELEASE-NOTES-1.24 M includes/Skin.php 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/29/135429/1 diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index 36efccc..26c23d0 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -91,6 +91,9 @@ * Added pp_sortkey column to page_props table, so pages can be efficiently queried and sorted by property value (bug 58032). See $wgPagePropsHaveSortkey if you want to postpone the schema change. +* The skin autodiscovery mechanism has been deprecated and will be removed in + MediaWiki 1.25. See https://www.mediawiki.org/wiki/Help:Skin_autodiscovery for + migration guide for creators and users of custom skins that relied on it. ==== Renamed classes ==== * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression diff --git a/includes/Skin.php b/includes/Skin.php index 2475e38..7f996d8 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -73,9 +73,19 @@ // This is one of the reasons we should have never used autodiscovery in the first // place. This hack can be safely removed when autodiscovery is gone. if ( in_array( $aSkin, array( 'CologneBlue', 'Modern', 'MonoBook', 'Vector' ) ) ) { + wfLogWarning( + "An old copy of the $aSkin skin was found in your skins/ directory. " . + "You should remove it to avoid problems in the future." . + "See https://www.mediawiki.org/wiki/Help:Skin_autodiscovery for details." + ); continue; } + wfLogWarning( + "A skin using autodiscovery mechanism, $aSkin, was found in your skins/ directory. " . + "The mechanism will be removed in MediaWiki 1.25 and the skin will no longer be recognized. " . + "See https://www.mediawiki.org/wiki/Help:Skin_autodiscovery for information how to fix this." + ); $wgValidSkinNames[strtolower( $aSkin )] = $aSkin; } } -- To view, visit https://gerrit.wikimedia.org/r/135429 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6fc30f97d4b35820c132c4892abf6d2c86f9482e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
