Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148671
Change subject: Fix bug in disconnect loop
......................................................................
Fix bug in disconnect loop
the loop counter after using it.
Change-Id: Id6702d382b6b4a45b783f4e2fa8d8099e28d43da
---
M src/EventEmitter.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/71/148671/1
diff --git a/src/EventEmitter.js b/src/EventEmitter.js
index 4849d10..82c3f3a 100644
--- a/src/EventEmitter.js
+++ b/src/EventEmitter.js
@@ -216,6 +216,7 @@
while ( i-- ) {
if ( bindings[i].context === context ) {
this.off( event, bindings[i].callback,
context );
+ i = bindings.length;
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/148671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6702d382b6b4a45b783f4e2fa8d8099e28d43da
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits