jenkins-bot has submitted this change and it was merged.
Change subject: Fix bug in disconnect loop
......................................................................
Fix bug in disconnect loop
Check if bindings[i] still exists on each step.
Change-Id: Id6702d382b6b4a45b783f4e2fa8d8099e28d43da
---
M src/EventEmitter.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/EventEmitter.js b/src/EventEmitter.js
index 4849d10..8fa06c3 100644
--- a/src/EventEmitter.js
+++ b/src/EventEmitter.js
@@ -214,7 +214,9 @@
bindings = this.bindings[event];
i = bindings.length;
while ( i-- ) {
- if ( bindings[i].context === context ) {
+ // bindings[i] may have been removed by the
previous step's
+ // this.off so check it still exists
+ if ( bindings[i] && bindings[i].context ===
context ) {
this.off( event, bindings[i].callback,
context );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/148671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6702d382b6b4a45b783f4e2fa8d8099e28d43da
Gerrit-PatchSet: 3
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
