Parent5446 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150240
Change subject: Added explicit type-cast to hash_pbkdf2
......................................................................
Added explicit type-cast to hash_pbkdf2
It seems HHVM does not like the use of
dynamic typing in hash_pbkdf2() (also it's
kind of not the best idea in general), so
added explicit (int) casting to parameters.
Change-Id: I8adae3cc2cdf8029be59e2d62a3ab0fbfb73b7aa
---
M includes/password/Pbkdf2Password.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/40/150240/1
diff --git a/includes/password/Pbkdf2Password.php
b/includes/password/Pbkdf2Password.php
index 417753f..080e3b0 100644
--- a/includes/password/Pbkdf2Password.php
+++ b/includes/password/Pbkdf2Password.php
@@ -51,8 +51,8 @@
$this->params['algo'],
$password,
base64_decode( $this->args[0] ),
- $this->params['rounds'],
- $this->params['length'],
+ (int)$this->params['rounds'],
+ (int)$this->params['length'],
true
);
} else {
--
To view, visit https://gerrit.wikimedia.org/r/150240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8adae3cc2cdf8029be59e2d62a3ab0fbfb73b7aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Parent5446 <tylerro...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
