jenkins-bot has submitted this change and it was merged. Change subject: Added explicit type-cast to hash_pbkdf2 ......................................................................
Added explicit type-cast to hash_pbkdf2 It seems HHVM does not like the use of dynamic typing in hash_pbkdf2() (also it's kind of not the best idea in general), so added explicit (int) casting to parameters. Follows-up: I0a9c972931a0eff0cfb2619cef3ddffd03710285 Change-Id: I8adae3cc2cdf8029be59e2d62a3ab0fbfb73b7aa --- M includes/password/Pbkdf2Password.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Chad: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/password/Pbkdf2Password.php b/includes/password/Pbkdf2Password.php index 417753f..080e3b0 100644 --- a/includes/password/Pbkdf2Password.php +++ b/includes/password/Pbkdf2Password.php @@ -51,8 +51,8 @@ $this->params['algo'], $password, base64_decode( $this->args[0] ), - $this->params['rounds'], - $this->params['length'], + (int)$this->params['rounds'], + (int)$this->params['length'], true ); } else { -- To view, visit https://gerrit.wikimedia.org/r/150240 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8adae3cc2cdf8029be59e2d62a3ab0fbfb73b7aa Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Parent5446 <tylerro...@gmail.com> Gerrit-Reviewer: Chad <ch...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits