Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/154794

Change subject: Remove preventDefault from settings.open
......................................................................

Remove preventDefault from settings.open

Bug: 69579
Change-Id: I6e457542060d147c35ccb2dfeade5b90f20bd2ca
---
M resources/ext.popups.settings.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/94/154794/1

diff --git a/resources/ext.popups.settings.js b/resources/ext.popups.settings.js
index 1d29630..bf62dab 100644
--- a/resources/ext.popups.settings.js
+++ b/resources/ext.popups.settings.js
@@ -119,7 +119,7 @@
         *
         * @method open
         */
-       settings.open = function ( e ) {
+       settings.open = function () {
                var
                        h = $( window ).height(),
                        w = $( window ).width();
@@ -131,7 +131,6 @@
                        .css( 'left', ( w - 600 ) / 2 )
                        .css( 'top', ( h - settings.$element.outerHeight( true 
) ) / 2 );
 
-               e.preventDefault();
                return false;
        };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/154794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e457542060d147c35ccb2dfeade5b90f20bd2ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to