jenkins-bot has submitted this change and it was merged.
Change subject: Remove preventDefault from settings.open
......................................................................
Remove preventDefault from settings.open
Bug: 69579
Change-Id: I6e457542060d147c35ccb2dfeade5b90f20bd2ca
---
M resources/ext.popups.settings.js
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
AndyRussG: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.settings.js b/resources/ext.popups.settings.js
index 1d29630..6da9a98 100644
--- a/resources/ext.popups.settings.js
+++ b/resources/ext.popups.settings.js
@@ -119,7 +119,7 @@
*
* @method open
*/
- settings.open = function ( e ) {
+ settings.open = function () {
var
h = $( window ).height(),
w = $( window ).width();
@@ -131,7 +131,6 @@
.css( 'left', ( w - 600 ) / 2 )
.css( 'top', ( h - settings.$element.outerHeight( true
) ) / 2 );
- e.preventDefault();
return false;
};
@@ -160,7 +159,10 @@
$( '<a>' )
.attr( 'href', '#)' )
.text( mw.message(
'popups-settings-enable' ).text() )
- .click( settings.open )
+ .click( function ( e ) {
+ settings.open();
+ e.preventDefault();
+ } )
),
$footer = $( '#footer-places, #f-list' );
--
To view, visit https://gerrit.wikimedia.org/r/154794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e457542060d147c35ccb2dfeade5b90f20bd2ca
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
