Dduvall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155781
Change subject: QA: Fixed "Upload image file" scenario
......................................................................
QA: Fixed "Upload image file" scenario
Removed implementation for the "I see an upload progress bar" step as
its too transient a condition to reliably test. The step itself was
left to serve the feature documentation.
Fixed issue with early element center calculation during the CSS
transition in Chrome by waiting until navigation links are fully
visible. (The Chrome webdriver always clicks the center of an element
and may fail to calculate the right coordinates during animations.)
Change-Id: I2c22e872a8772090d0f508f6c7fa6df78b891a50
---
M tests/browser/features/special_uploads.feature
M tests/browser/features/step_definitions/mainmenu_steps.rb
M tests/browser/features/step_definitions/uploads_steps.rb
M tests/browser/features/support/pages/article_page.rb
4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/81/155781/1
diff --git a/tests/browser/features/special_uploads.feature
b/tests/browser/features/special_uploads.feature
index 8a67bbb..67299d1 100644
--- a/tests/browser/features/special_uploads.feature
+++ b/tests/browser/features/special_uploads.feature
@@ -1,4 +1,4 @@
-@chrome @en.m.wikipedia.beta.wmflabs.org @login @test2.m.wikipedia.org @vagrant
+@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login
@test2.m.wikipedia.org @vagrant
Feature: Special:Uploads uploads
Background:
Given I am using the mobile site
@@ -34,6 +34,6 @@
When I upload file "exif.jpg"
And I type a description
And I click Upload
- Then I see an upload progress bar
- And my image is on the Uploads page
+ Then I see a progress bar while it uploads
+ And my image eventually appears on the Uploads page
And the Contribute an image button is visible
diff --git a/tests/browser/features/step_definitions/mainmenu_steps.rb
b/tests/browser/features/step_definitions/mainmenu_steps.rb
index dbc926f..141830d 100644
--- a/tests/browser/features/step_definitions/mainmenu_steps.rb
+++ b/tests/browser/features/step_definitions/mainmenu_steps.rb
@@ -4,7 +4,7 @@
When(/^I click on "(.*?)" in the main navigation menu$/) do |text|
step 'I click on the main navigation button'
- on(ArticlePage).navigation_element.link_element(text: text).click
+ on(ArticlePage).navigation_element.link_element(text:
text).when_visible.click
end
Then(/^I see a link to "(.*?)" in the main navigation menu$/) do |text|
diff --git a/tests/browser/features/step_definitions/uploads_steps.rb
b/tests/browser/features/step_definitions/uploads_steps.rb
index 452be77..b0aa48f 100644
--- a/tests/browser/features/step_definitions/uploads_steps.rb
+++ b/tests/browser/features/step_definitions/uploads_steps.rb
@@ -18,7 +18,7 @@
on(UploadPage).photo_description_element.when_present.send_keys("Describing
with #{@random_string}")
end
-Then(/^my image is on the Uploads page$/) do
+Then(/^my image eventually appears on the Uploads page$/) do
on(UploadPage) do |page|
page.wait_until(10) do
page.text.include? "#{@random_string}" #Chrome needs this, FF does not
@@ -52,8 +52,9 @@
on(ArticlePage).photo_overlay_element.should_not be_visible
end
-Then(/^I see an upload progress bar$/) do
- on(ArticlePage).progress_header_element.should be_visible
+Then(/^I see a progress bar while it uploads$/) do
+ # this step is too transient to reliably test, but leave it for
+ # feature documentation
end
When(/^I upload file "(.*?)"$/) do |file_name|
diff --git a/tests/browser/features/support/pages/article_page.rb
b/tests/browser/features/support/pages/article_page.rb
index 6e8efb3..5d317f3 100644
--- a/tests/browser/features/support/pages/article_page.rb
+++ b/tests/browser/features/support/pages/article_page.rb
@@ -74,7 +74,6 @@
button(:notifications_overlay_close_button) do |page|
page.notifications_overlay_element.button_element(class: "cancel")
end
- h2(:progress_header, class: "uploading")
a(:image_link, class:"image")
--
To view, visit https://gerrit.wikimedia.org/r/155781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c22e872a8772090d0f508f6c7fa6df78b891a50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Dduvall <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
