Hello Ottomata,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/155782

to review the following change.

Change subject: Bump collector's receive buffer to 512MB
......................................................................

Bump collector's receive buffer to 512MB

We are seeing UDP buffer receive errors, and it seems that kafkatee is
way burstier than udp2log was. So we're bumping the receive buffer, to
better handle the bursts.

Change-Id: Ia562b9277aa85b20ceaeef6eaee0a9c4a728cd2c
---
M collector.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/webstatscollector 
refs/changes/82/155782/1

diff --git a/collector.c b/collector.c
index 13c8055..b97ba5a 100644
--- a/collector.c
+++ b/collector.c
@@ -53,6 +53,7 @@
        /* Socket variables */
        int s, exp;
        u_int yes=1;
+       u_int recv_buffer = 512 * 1024 * 1024; // 512MB
        int port;
        struct sockaddr_in me, them;
        socklen_t sl;
@@ -70,6 +71,7 @@
 
                exp=socket(AF_INET,SOCK_STREAM,0);
                setsockopt(exp,SOL_SOCKET,SO_REUSEADDR,&yes,sizeof(yes));
+               
setsockopt(exp,SOL_SOCKET,SO_RCVBUF,&recv_buffer,sizeof(recv_buffer));
                bind(exp,(struct sockaddr *)&me,sizeof(me));
                listen(exp,10);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/155782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia562b9277aa85b20ceaeef6eaee0a9c4a728cd2c
Gerrit-PatchSet: 1
Gerrit-Project: analytics/webstatscollector
Gerrit-Branch: kafka
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to