Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/159957

Change subject: Fix JS error due to typo in dm.Converter
......................................................................

Fix JS error due to typo in dm.Converter

The typo was in an unused code path that only runs when
toDataElement returns null/undefined.

Change-Id: I741605fb3d1403f163dade7cbc3151aef23e46ec
---
M src/dm/ve.dm.Converter.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/57/159957/1

diff --git a/src/dm/ve.dm.Converter.js b/src/dm/ve.dm.Converter.js
index 404e85c..00349b8 100644
--- a/src/dm/ve.dm.Converter.js
+++ b/src/dm/ve.dm.Converter.js
@@ -666,7 +666,7 @@
                                        modelClass = ve.dm.AlienNode;
                                        childNodes = 
modelClass.static.enableAboutGrouping ?
                                                aboutGroup : [ childNode ];
-                                       childDataElements = 
this.createDataElement( modelClass, childNodes );
+                                       childDataElements = 
this.createDataElements( modelClass, childNodes );
                                } else {
                                        // Update modelClass to reflect the 
type we got back
                                        modelClass = this.modelRegistry.lookup( 
childDataElements[0].type );

-- 
To view, visit https://gerrit.wikimedia.org/r/159957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I741605fb3d1403f163dade7cbc3151aef23e46ec
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to