jenkins-bot has submitted this change and it was merged.
Change subject: Fix JS error due to typo in dm.Converter
......................................................................
Fix JS error due to typo in dm.Converter
The typo was in an unused code path that only runs when
toDataElement returns null/undefined.
Change-Id: I741605fb3d1403f163dade7cbc3151aef23e46ec
---
M src/dm/ve.dm.Converter.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/dm/ve.dm.Converter.js b/src/dm/ve.dm.Converter.js
index 404e85c..00349b8 100644
--- a/src/dm/ve.dm.Converter.js
+++ b/src/dm/ve.dm.Converter.js
@@ -666,7 +666,7 @@
modelClass = ve.dm.AlienNode;
childNodes =
modelClass.static.enableAboutGrouping ?
aboutGroup : [ childNode ];
- childDataElements =
this.createDataElement( modelClass, childNodes );
+ childDataElements =
this.createDataElements( modelClass, childNodes );
} else {
// Update modelClass to reflect the
type we got back
modelClass = this.modelRegistry.lookup(
childDataElements[0].type );
--
To view, visit https://gerrit.wikimedia.org/r/159957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I741605fb3d1403f163dade7cbc3151aef23e46ec
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
