Hello Ottomata,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/165617

to review the following change.

Change subject: Use GNU Make's implicit rm
......................................................................

Use GNU Make's implicit rm

Change-Id: I818bc8a68fb9ec50360c2bfe107e2215f5543db3
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/webstatscollector 
refs/changes/17/165617/1

diff --git a/Makefile b/Makefile
index 730047f..e146d43 100644
--- a/Makefile
+++ b/Makefile
@@ -28,7 +28,7 @@
        gcc -c -o export.o export.c
 
 clean:
-       rm -f *.o collector filter
+       $(RM) *.o collector filter
        $(MAKE) clean-recursive
 
 check: filter

-- 
To view, visit https://gerrit.wikimedia.org/r/165617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I818bc8a68fb9ec50360c2bfe107e2215f5543db3
Gerrit-PatchSet: 1
Gerrit-Project: analytics/webstatscollector
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to