jenkins-bot has submitted this change and it was merged.
Change subject: Add missing HTML element slashes to jQuery calls
......................................................................
Add missing HTML element slashes to jQuery calls
Not sure about the space. I love to have it for the sake of readability.
I find that much easier to read. Our code base currently uses both, a
lot without space but also a lot with space. Can we agree on the space?
Otherwise I will remove it everywhere.
Change-Id: I87d0c5361305d883d8a37e2dd6f1ec8f691b7104
---
M lib/resources/jquery.ui/jquery.ui.tagadata.js
M lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
M lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
M lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
M lib/resources/jquery.wikibase/snakview/snakview.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityselector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.pagesuggester.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
8 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.ui/jquery.ui.tagadata.js
b/lib/resources/jquery.ui/jquery.ui.tagadata.js
index 084f579..95c9dca 100644
--- a/lib/resources/jquery.ui/jquery.ui.tagadata.js
+++ b/lib/resources/jquery.ui/jquery.ui.tagadata.js
@@ -307,7 +307,7 @@
}
var $label = $( '<span/>' ).addClass( 'tagadata-label' ),
- $input = $( '<input>' ).attr( 'name',
this.options.itemName + '[]' );
+ $input = $( '<input />' ).attr( 'name',
this.options.itemName + '[]' );
$tag = this._createTagNode().addClass( additionalClasses || ''
).append( $label );
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
index 79cef38..23a9a5f 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
@@ -130,7 +130,7 @@
$.uls.data.getDir( this.options.value.language ) :
$( 'html' ).prop( 'dir' );
- var $input = $( '<input>', {
+ var $input = $( '<input />', {
// TODO: Inject correct placeholder via options
placeholder: mw.msg(
'wikibase-description-edit-placeholder-language-aware',
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
index 24f69f8..ff93134 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
@@ -142,7 +142,7 @@
$.uls.data.getDir( this.options.value.language ) :
$( 'html' ).prop( 'dir' );
- var $input = $( '<input>', {
+ var $input = $( '<input />', {
// TODO: Inject correct placeholder via options
placeholder: mw.msg(
'wikibase-label-edit-placeholder-language-aware',
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
index f3016f7..fdf0033 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
@@ -202,7 +202,7 @@
};
}
- var $pageNameInput = $( '<input/>' )
+ var $pageNameInput = $( '<input />' )
.attr( 'placeholder', mw.msg(
'wikibase-sitelink-page-edit-placeholder' ) )
.pagesuggester( pageNameInputOptions );
@@ -221,7 +221,7 @@
return;
}
- var $siteIdInput = $( '<input/>' )
+ var $siteIdInput = $( '<input />' )
.attr( 'placeholder', mw.msg(
'wikibase-sitelink-site-edit-placeholder' ) )
.siteselector( {
source: $.map( this.option( 'getAllowedSiteIds'
)(), function( siteId ) {
diff --git a/lib/resources/jquery.wikibase/snakview/snakview.js
b/lib/resources/jquery.wikibase/snakview/snakview.js
index f387a9f..bb7450d 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.js
@@ -216,7 +216,7 @@
repoConfig = mw.config.get( 'wbRepo' ),
repoApiUrl = repoConfig.url + repoConfig.scriptPath +
'/api.php';
- return $( '<input/>' ).entityselector( {
+ return $( '<input />' ).entityselector( {
url: repoApiUrl,
type: 'property'
} )
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityselector.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityselector.tests.js
index 7df2270..f4d24a2 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityselector.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityselector.tests.js
@@ -38,7 +38,7 @@
source: entityStubs
}, options || {} );
- return $( '<input/>' )
+ return $( '<input />' )
.addClass( 'test-entityselector')
.appendTo( 'body' )
.entityselector( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.pagesuggester.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.pagesuggester.tests.js
index abd1970..4b7eb50 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.pagesuggester.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.pagesuggester.tests.js
@@ -11,7 +11,7 @@
* @param {Object} [options]
*/
var newTestPageSuggester = function( options ) {
- return $( '<input/>' )
+ return $( '<input />' )
.addClass( 'test_pagesuggester')
.appendTo( 'body' )
.pagesuggester( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
index 2338aea..5c8e04f 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
@@ -81,7 +81,7 @@
var newTestSiteSelector = function( options ) {
options = $.merge( { source: sites }, options || {} );
- return $( '<input/>' ).addClass( 'test-siteselector'
).siteselector( options );
+ return $( '<input />' ).addClass( 'test-siteselector'
).siteselector( options );
};
QUnit.module( 'jquery.wikibase.siteselector', QUnit.newMwEnvironment( {
--
To view, visit https://gerrit.wikimedia.org/r/167174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87d0c5361305d883d8a37e2dd6f1ec8f691b7104
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
