Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/185179
to review the following change.
Change subject: Explain why tables that should be external are internal
......................................................................
Explain why tables that should be external are internal
Change-Id: I0d8429cfbcec6966cecc6cb30a6f72e04ba101dd
---
M hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql
M hive/webrequest/create_webrequest_table.hql
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery
refs/changes/79/185179/1
diff --git a/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql
b/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql
index 887b0be..b6c4cb4 100644
--- a/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql
+++ b/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql
@@ -23,6 +23,11 @@
-- +--------------+---------------------------+--------------+
-- (For 2014-09-15T12:xx:xx)
--
+-- Actually, the table should be external. But since we have
+-- hive.insert.into.external.tables to false, we're forced to having
+-- it internal for now, as otherwise we could not insert into that
+-- table.
+--
-- Parameters:
-- <none>
--
diff --git a/hive/webrequest/create_webrequest_table.hql
b/hive/webrequest/create_webrequest_table.hql
index c8c326e..09285e1 100644
--- a/hive/webrequest/create_webrequest_table.hql
+++ b/hive/webrequest/create_webrequest_table.hql
@@ -8,6 +8,11 @@
-- and
-- http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-analytics/20140721.txt
--
+-- Actually, the table should be external. But since we have
+-- hive.insert.into.external.tables to false, we're forced to having
+-- it internal for now, as otherwise we could not insert into that
+-- table.
+--
-- Parameters:
-- <none>
--
--
To view, visit https://gerrit.wikimedia.org/r/185179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d8429cfbcec6966cecc6cb30a6f72e04ba101dd
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
