Ottomata has submitted this change and it was merged. Change subject: Explain why tables that should be external are internal ......................................................................
Explain why tables that should be external are internal Change-Id: I0d8429cfbcec6966cecc6cb30a6f72e04ba101dd --- M hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ottomata: Verified; Looks good to me, approved diff --git a/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql b/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql index 887b0be..59cd875 100644 --- a/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql +++ b/hive/pagecounts-all-sites/create_pagecounts_all_sites_table.hql @@ -23,6 +23,12 @@ -- +--------------+---------------------------+--------------+ -- (For 2014-09-15T12:xx:xx) -- +-- Actually, the table should be external. But when it got created, +-- hive.insert.into.external.tables was still set to false. Hence, we have been +-- forced to having it internal back then, as otherwise we could not insert into +-- that table from within Hive. Now that Hive allows to insert into external +-- tables, this table can be turned into an external table. +-- -- Parameters: -- <none> -- -- To view, visit https://gerrit.wikimedia.org/r/185179 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d8429cfbcec6966cecc6cb30a6f72e04ba101dd Gerrit-PatchSet: 4 Gerrit-Project: analytics/refinery Gerrit-Branch: master Gerrit-Owner: QChris <[email protected]> Gerrit-Reviewer: Ottomata <[email protected]> Gerrit-Reviewer: QChris <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
