jenkins-bot has submitted this change and it was merged.
Change subject: MathRenderer, SpecialMathShowImage: Correct phpdoc
......................................................................
MathRenderer, SpecialMathShowImage: Correct phpdoc
Change-Id: Ibce076dfb6bd3676e288cf2d762ebcb55606246d
---
M MathRenderer.php
M SpecialMathShowImage.php
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MathRenderer.php b/MathRenderer.php
index 651d244..7139da0 100644
--- a/MathRenderer.php
+++ b/MathRenderer.php
@@ -99,7 +99,7 @@
/**
*
- * @param type $md5
+ * @param string $md5
* @return MathRenderer the MathRenderer generated from md5
*/
public static function newFromMd5( $md5 ) {
@@ -652,7 +652,7 @@
}
/**
- * @return string Userdefined ID
+ * @param string user defined ID
*/
public function setID( $id ) {
// Changes in the ID affect the container for the math element
on the current page
diff --git a/SpecialMathShowImage.php b/SpecialMathShowImage.php
index 5e70590..7b5fda1 100644
--- a/SpecialMathShowImage.php
+++ b/SpecialMathShowImage.php
@@ -16,8 +16,10 @@
false // Don't show on Special:SpecialPages - it's not
useful interactively
);
}
+
/**
* Sets headers - this should be called from the execute() method of
all derived classes!
+ * @param bool $success
*/
function setHeaders( $success = true ) {
$out = $this->getOutput();
--
To view, visit https://gerrit.wikimedia.org/r/178510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibce076dfb6bd3676e288cf2d762ebcb55606246d
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits