jenkins-bot has submitted this change and it was merged.
Change subject: MathMathML, MathTexvc: Improve PhpDoc
......................................................................
MathMathML, MathTexvc: Improve PhpDoc
Change-Id: I84af65e15bdae81f69f0444afdd9ffa5fe9fc326
---
M MathMathML.php
M MathTexvc.php
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MathMathML.php b/MathMathML.php
index 6707059..f07be9e 100644
--- a/MathMathML.php
+++ b/MathMathML.php
@@ -156,7 +156,7 @@
$options = array( 'method' => 'POST', 'postData' => $post,
'timeout' => $wgMathLaTeXMLTimeout );
/** @var $req (CurlHttpRequest|PhpHttpRequest) the request
object */
$req = $httpRequestClass::factory( $host, $options );
- /** @var Status the request status */
+ /** @var Status $req Status the request status */
$status = $req->execute();
if ( $status->isGood() ) {
$res = $req->getContent();
diff --git a/MathTexvc.php b/MathTexvc.php
index e76100c..562af16 100644
--- a/MathTexvc.php
+++ b/MathTexvc.php
@@ -55,6 +55,7 @@
/**
* @param database_row $rpage
+ * @return bool
*/
protected function initializeFromDatabaseRow( $rpage ) {
parent::initializeFromDatabaseRow( $rpage );
--
To view, visit https://gerrit.wikimedia.org/r/178511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84af65e15bdae81f69f0444afdd9ffa5fe9fc326
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <[email protected]>
Gerrit-Reviewer: Frédéric Wang <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
