Filippo Giunchedi has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/186418

Change subject: fix check_elasticsearch CRITICAL output
......................................................................

fix check_elasticsearch CRITICAL output

format cluster health according to _format_health otherwise the output text is
garbled on IRC with 's removed, e.g:

{ustatus: uyellow, unumber_of_nodes: 3, uunassigned_shards: 11, utimed_out:

Change-Id: I9193bb90ba1a67f31077c346cf3c5c1e0712c2a1
---
M modules/elasticsearch/files/nagios/check_elasticsearch.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/18/186418/1

diff --git a/modules/elasticsearch/files/nagios/check_elasticsearch.py 
b/modules/elasticsearch/files/nagios/check_elasticsearch.py
index b6271ce..fc10cb8 100755
--- a/modules/elasticsearch/files/nagios/check_elasticsearch.py
+++ b/modules/elasticsearch/files/nagios/check_elasticsearch.py
@@ -111,7 +111,7 @@
         return EX_OK
 
     log_critical('inactive shards %s threshold %s breach: %r' % (
-                 inactive_shards, threshold, health))
+                 inactive_shards, threshold, _format_health(health)))
     return EX_CRITICAL
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/186418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9193bb90ba1a67f31077c346cf3c5c1e0712c2a1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to