Filippo Giunchedi has submitted this change and it was merged.
Change subject: fix check_elasticsearch CRITICAL output
......................................................................
fix check_elasticsearch CRITICAL output
format cluster health according to _format_health otherwise the output text is
garbled on IRC with 's removed, e.g:
{ustatus: uyellow, unumber_of_nodes: 3, uunassigned_shards: 11, utimed_out:
Change-Id: I9193bb90ba1a67f31077c346cf3c5c1e0712c2a1
---
M modules/elasticsearch/files/nagios/check_elasticsearch.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Chad: Looks good to me, but someone else must approve
Filippo Giunchedi: Verified; Looks good to me, approved
diff --git a/modules/elasticsearch/files/nagios/check_elasticsearch.py
b/modules/elasticsearch/files/nagios/check_elasticsearch.py
index b6271ce..fc10cb8 100755
--- a/modules/elasticsearch/files/nagios/check_elasticsearch.py
+++ b/modules/elasticsearch/files/nagios/check_elasticsearch.py
@@ -111,7 +111,7 @@
return EX_OK
log_critical('inactive shards %s threshold %s breach: %r' % (
- inactive_shards, threshold, health))
+ inactive_shards, threshold, _format_health(health)))
return EX_CRITICAL
--
To view, visit https://gerrit.wikimedia.org/r/186418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9193bb90ba1a67f31077c346cf3c5c1e0712c2a1
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
