Dduvall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189832
Change subject: Additional documentation on upgrading to 1.0.0
......................................................................
Additional documentation on upgrading to 1.0.0
Change-Id: Iad407621d01e0ec42e54ee10fa0c71019c50b1e9
---
M UPGRADE.md
1 file changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/32/189832/1
diff --git a/UPGRADE.md b/UPGRADE.md
index 8be0943..8d98cec 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -58,3 +58,28 @@
# ...
end
+
+## Refactor direct use of `ENV`
+
+Change all references to `ENV` to use the appropriate `Environment` method.
+For example, change things like this.
+
+ Given(/^I am logged in to the primary wiki domain$/) do
+ visit(LoginPage).login_with(ENV["MEDIAWIKI_USER"],
ENV["MEDIAWIKI_PASSWORD"])
+ end
+
+To something like this. (Both `user` and `password` are methods of
+`Environment`.)
+
+ Given(/^I am logged in to the primary wiki domain$/) do
+ visit(LoginPage).login_with(user, password)
+ end
+
+Environment configuration that isn't accessible via a method of `Environment`
+can still be read via `Environment#lookup` and `Environment#[]`.
+
+## Remove direct references to `@browser`
+
+All references to `@browser` should use `Environment#browser` instead, since
+the latter will automatically configure and launch the browser the first time
+it's needed.
--
To view, visit https://gerrit.wikimedia.org/r/189832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad407621d01e0ec42e54ee10fa0c71019c50b1e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Dduvall <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
