jenkins-bot has submitted this change and it was merged.
Change subject: Additional documentation on upgrading to 1.0.0
......................................................................
Additional documentation on upgrading to 1.0.0
Change-Id: Iad407621d01e0ec42e54ee10fa0c71019c50b1e9
---
M UPGRADE.md
1 file changed, 55 insertions(+), 0 deletions(-)
Approvals:
Dduvall: Looks good to me, approved
jenkins-bot: Verified
diff --git a/UPGRADE.md b/UPGRADE.md
index 8be0943..df5c15c 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -58,3 +58,58 @@
# ...
end
+
+## Refactor direct use of `ENV`
+
+Change all references to `ENV` to use the appropriate `Environment` method.
+
+For example, change things like:
+
+ Given(/^I am logged in to the primary wiki domain$/) do
+ visit(LoginPage).login_with(ENV["MEDIAWIKI_USER"],
ENV["MEDIAWIKI_PASSWORD"])
+ end
+
+To something like:
+
+ Given(/^I am logged in to the primary wiki domain$/) do
+ visit(LoginPage).login_with(user, password)
+ end
+
+More esoteric configuration that isn't accessible via a method of
+`Environment` can still be read via `Environment#lookup` and `Environment#[]`.
+
+Change something like the following:
+
+ Then(/^the default language should reflect my browser language$/) do
+ on(PreferencesPage) do |page|
+ expect(page.language_preference).to eq(ENV['BROWSER_LANGUAGE'])
+ end
+ end
+
+To something like:
+
+ Then(/^the default language should reflect my browser language$/) do
+ on(PreferencesPage) do |page|
+ expect(page.language_preference).to eq(env[:browser_language])
+ # or
+ expect(page.language_preference).to eq(lookup(:browser_language))
+ end
+ end
+
+## Remove direct references to `@browser`
+
+All references to `@browser` should use `Environment#browser` instead, since
+the latter will automatically configure and launch the browser the first time
+it's needed.
+
+For example:
+
+ When(/^I am viewing Topic page$/) do
+ on(FlowPage).wait_until { @browser.url =~ /Topic/ }
+ end
+
+Would be changed to:
+
+ When(/^I am viewing Topic page$/) do
+ on(FlowPage).wait_until { browser.url =~ /Topic/ }
+ end
--
To view, visit https://gerrit.wikimedia.org/r/189832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad407621d01e0ec42e54ee10fa0c71019c50b1e9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Dduvall <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Dduvall <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
